-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Geometry Analysis and Coverage Dependence Part 1 #46
Open
mjohnson541
wants to merge
183
commits into
master
Choose a base branch
from
cov_dep
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otherwise issues can occur with constraints during the structure comparison
note RMG has a function for doing this, but it is too slow for the graphs including all surface sites
…nerate an electronic representation of molecule
this is mostly to faciliate visualization of sites
…ite identities) a particular adsorbate can have
Enable T boltzmann weighted contributions to the weight vector reloop the greedy optimization to improve convergence to local minimum fix NaN related bugs
…cting configurations to calculate
This helps ensure the the only long path in the decomposition is between the two target adsorbates, but still provides room around each target adsorbate to enable accounting for many body interactions
enforces strict N_nodes = node_fract_training*N_training_points
since ontop sites are higher above the lattice than bridge and hollow sites the bond length can be a bit longer. important for vdW species as well like NH3*
lets fix_bond_orders be passed flags causing it to preserve vdW for bonds that connect an otherwise gas-phase species to the surface and to include all vdW surface bonds
…at use fix_bond_orders
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a lot of technology developed for coverage dependence, primarily a set of tools for doing 3D to 2D for adsorbates and transition states.