Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geometry Analysis and Coverage Dependence Part 1 #46

Open
wants to merge 183 commits into
base: master
Choose a base branch
from

Conversation

mjohnson541
Copy link
Contributor

@mjohnson541 mjohnson541 commented Apr 24, 2024

This adds a lot of technology developed for coverage dependence, primarily a set of tools for doing 3D to 2D for adsorbates and transition states.

mjohnson541 added 29 commits May 3, 2024 13:59
otherwise issues can occur with constraints during the structure comparison
note RMG has a function for doing this, but it is too slow for the graphs including all surface sites
…nerate an electronic representation of molecule
this is mostly to faciliate visualization of sites
…ite identities) a particular adsorbate can have
Enable T boltzmann weighted contributions to the weight vector
reloop the greedy optimization to improve convergence to local minimum
fix NaN related bugs
This helps ensure the the only long path in the decomposition is between the two target adsorbates, but still provides room around each target adsorbate to enable accounting for many body interactions
enforces strict N_nodes = node_fract_training*N_training_points
since ontop sites are higher above the lattice than bridge and hollow sites the bond length can be a bit longer.
important for vdW species as well like NH3*
lets fix_bond_orders be passed flags causing it to preserve vdW for bonds that connect an otherwise gas-phase species to the surface and to include all vdW surface bonds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants